[code-quality] Add ScalarArgumentToExpectedParamTypeRector#533
Merged
TomasVotruba merged 2 commits intomainfrom Sep 3, 2025
Merged
[code-quality] Add ScalarArgumentToExpectedParamTypeRector#533TomasVotruba merged 2 commits intomainfrom
TomasVotruba merged 2 commits intomainfrom
Conversation
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-tests-pass-arg-retype
branch
from
012ad6b to
16e08d3
Compare
TomasVotruba
force-pushed
the
tv-tests-pass-arg-retype
branch
from
df8e703 to
bca109c
Compare
samsonasik
reviewed
Sep 3, 2025
| } | ||
|
|
||
| $scope = ScopeFetcher::fetch($call); | ||
| $extendedMethodReflection = $classReflection->getMethod($methodName, $scope); |
Member
There was a problem hiding this comment.
Suggested change
| $extendedMethodReflection = $classReflection->getMethod($methodName, $scope); | |
| $extendedMethodReflection = $classReflection->getNativeMethod($methodName); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, test pass invalid type of scalar value. But this type is already defined in the method parameter.
Let's alling tests with code in automated fashion 🥳
use PHPUnit\Framework\TestCase; final class SimpleMethodCall extends TestCase { public function test() { $someClassWithSetter = new SomeClassWithSetter(); - $someClassWithSetter->setPhoneNumber(123456); + $someClassWithSetter->setPhoneNumber('123456'); } }